Skip to content

Move all arguments out of macro file #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move all arguments out of macro file #495

wants to merge 1 commit into from

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 5, 2022

This way it can be included more easily.

@p0rys this should fix the problems mentioned in #482.

@p0rys
Move all arguments out of macro file
4ec09e5 
This way it can be included more easily.
@fmauch fmauch mentioned this pull request Oct 5, 2022
Closed
@gavanderhoorn
Copy link
Contributor

Would be even better if there would be a way to keep the ros2_control block out of the default macro completely.

It's really rather awkward having that present in all cases. The changes in this PR seem to also highlight that.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (foxy@e448b15). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@          Coverage Diff           @@
##             foxy    #495   +/-   ##
======================================
  Coverage        ?   3.73%           
======================================
  Files           ?      16           
  Lines           ?    1071           
  Branches        ?     212           
======================================
  Hits            ?      40           
  Misses          ?     942           
  Partials        ?      89
Flag Coverage Δ
unittests 3.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmauch
Copy link
Contributor Author

fmauch commented Oct 5, 2022

Would be even better if there would be a way to keep the ros2_control block out of the default macro completely.

It's really rather awkward having that present in all cases. The changes in this PR seem to also highlight that.

I do agree on the awkward part, but so far I couldn't come up with a satisfying solution. I've started #496 to share my concerns. Maybe we can discuss things there a bit to migrate to a proper solution?

@fmauch fmauch added the Foxy label Oct 5, 2022
@fmauch
Copy link
Contributor Author

fmauch commented May 9, 2023

@RobertWilbrandt a review on this would be appreciated before we put Foxy to its EOL sleep.

@fmauch
Copy link
Contributor Author

fmauch commented Jun 28, 2023

Closing this, since Foxy is no longer updated.

@fmauch fmauch closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertWilbrandt RobertWilbrandt Awaiting requested review from RobertWilbrandt

@urmahp urmahp Awaiting requested review from urmahp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmauch @gavanderhoorn @p0rys